Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 )
Change subject: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21409/3/testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test File testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test: http://gerrit.cloudera.org:8080/#/c/21409/3/testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test@135 PS3, Line 135: ==== : select s_store_id as store_id, nit: Can you put some comment for the new tests? What is the expectation of each test. -- To view, visit http://gerrit.cloudera.org:8080/21409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd7e28b8d5f11f25a000dc4c9ab65895056b572 Gerrit-Change-Number: 21409 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 10 May 2024 01:45:48 +0000 Gerrit-HasComments: Yes
