Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 )
Change subject: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21409/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21409/2//COMMIT_MSG@21 PS2, Line 21: Note that explicate castings on base columns are not allowed to nit: explicate -> explicit castings -> casting http://gerrit.cloudera.org:8080/#/c/21409/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21409/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@294 PS2, Line 294: // Explicate castings are not allowed to pushdown. spelling: Explicate -> Explicit The else case seems to cover all other binary predicate scenarios like: * Both operands are slot references * One or both of the operands is an expression using SlotRef such as explicit CAST, built-in functions, arithmetic expressions, etc,. Can we also test built-in functions, we may have to block their pushdown also if TBinaryPredicate doesn't support them. This is probably beyond the scope of this ticket so we can also look into this separately. select * from table where (int_col + 2) > 10 select * from table where length(string_col) < 5 -- To view, visit http://gerrit.cloudera.org:8080/21409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd7e28b8d5f11f25a000dc4c9ab65895056b572 Gerrit-Change-Number: 21409 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2024 21:46:53 +0000 Gerrit-HasComments: Yes
