Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 )
Change subject: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21409/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21409/2//COMMIT_MSG@21 PS2, Line 21: Note that explicit casting on base columns are not allowed to > nit: Fixed http://gerrit.cloudera.org:8080/#/c/21409/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21409/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@294 PS2, Line 294: // Other binary predicate scenarios are not accepted, including: > spelling: Updated comments and added planner tests for explicit CAST, built-in functions, arithmetic expressions. Those predicates, built-in function, expressions are not pushed down to JDBC, e.g. not in "data source predicates", but in "predicates" of DataSourceScaNode so that those casting, built-in functions and expressions will be executed on coordinator. http://gerrit.cloudera.org:8080/#/c/21409/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@301 PS2, Line 301: lExpr instanceof CastExpr) { : CastExpr castExpr = (CastExpr)colExpr; > nit: Any new planner test for this? Added planner tests for explicit CAST, implicit casting to date/timestamp, which shows those predicates are not pushed down to JDBC, e.g. not in "data source predicates" -- To view, visit http://gerrit.cloudera.org:8080/21409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd7e28b8d5f11f25a000dc4c9ab65895056b572 Gerrit-Change-Number: 21409 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 10 May 2024 00:56:59 +0000 Gerrit-HasComments: Yes
