Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 )
Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21493/2/be/src/exprs/ai-functions-ir.cc File be/src/exprs/ai-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/21493/2/be/src/exprs/ai-functions-ir.cc@27 PS2, Line 27: ai_endpoint > rename as default_ai_endpoint Renaming will be tricky since this is part of 4.4.0. We can clarify this in the documentation also? http://gerrit.cloudera.org:8080/#/c/21493/2/be/src/exprs/ai-functions-ir.cc@154 PS2, Line 154: switch(platform) { : case AI_PLATFORM::OPEN_AI: : return AiGenerateTextInternal<false, AI_PLATFORM::OPEN_AI>( : ctx, endpoint_sv, prompt, model, api_key_jceks_secret, params, false); : case AI_PLATFORM::AZURE_OPEN_AI: : return AiGenerateTextInternal<false, AI_PLATFORM::AZURE_OPEN_AI>( : ctx, endpoint_sv, prompt, model, api_key_jceks_secret, params, false); : default: > simplify as: This won't work because the template parameter 'platform' must be known at compile time and cannot be a variable. http://gerrit.cloudera.org:8080/#/c/21493/2/be/src/exprs/ai-functions-ir.cc@178 PS2, Line 178: default: > add DCHECK since the default endpoint must be supported. Done -- To view, visit http://gerrit.cloudera.org:8080/21493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9cc07940ce355d511bcf0ee615ff31042d13eb5 Gerrit-Change-Number: 21493 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 08 Jun 2024 22:42:37 +0000 Gerrit-HasComments: Yes
