Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 )
Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21493/3/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/21493/3/be/src/exprs/ai-functions.inline.h@75 PS3, Line 75: getAuthorizationHeader > If it is an unsupported platform, would it be better to throw an error and It's not possible to get 'UnSupported Platform' in getAuthorizationHeader() because we check for platform in the caller function and return error for unsupported platform. Added a Status check and error handling in case this assumption ever changes. http://gerrit.cloudera.org:8080/#/c/21493/3/be/src/exprs/ai-functions.inline.h@75 PS3, Line 75: getAuthorizationHeader<platform>() + api_key > Also would it be better to combine the api_key as a parameter to getAuthori Done -- To view, visit http://gerrit.cloudera.org:8080/21493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9cc07940ce355d511bcf0ee615ff31042d13eb5 Gerrit-Change-Number: 21493 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 10 Jun 2024 14:37:26 +0000 Gerrit-HasComments: Yes
