Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 )
Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21493/3/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/21493/3/be/src/exprs/ai-functions.inline.h@75 PS3, Line 75: getAuthorizationHeader If it is an unsupported platform, would it be better to throw an error and return earlier here instead of putting "Unsupported Platform" to the header? How about returning an empty string or null if not supported in getAuthorizationHeader(), so that the caller would take less cost to validate it, or maybe using a Status and a string pointer as the return from getAuthorizationHeader()? http://gerrit.cloudera.org:8080/#/c/21493/3/be/src/exprs/ai-functions.inline.h@75 PS3, Line 75: getAuthorizationHeader<platform>() + api_key Also would it be better to combine the api_key as a parameter to getAuthorizationHeader()? It seems more readable. -- To view, visit http://gerrit.cloudera.org:8080/21493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9cc07940ce355d511bcf0ee615ff31042d13eb5 Gerrit-Change-Number: 21493 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sun, 09 Jun 2024 02:55:27 +0000 Gerrit-HasComments: Yes
