Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 )
Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21493/4/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/21493/4/be/src/exprs/ai-functions.inline.h@79 PS4, Line 79: Status status = getAuthorizationHeader<platform>(authHeader, ai_api_key_); : if (!status.ok()) return copyErrorMessage(ctx, status.msg().msg()); > nit. can we use a macro to simplify error handling in this case? If not, th It looks like gcc doesn't like passing templatized function as an argument to macros. I get following errors: error: unterminated argument list invoking macro "RETURN_STRINGVAL_IF_ERROR" -- To view, visit http://gerrit.cloudera.org:8080/21493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9cc07940ce355d511bcf0ee615ff31042d13eb5 Gerrit-Change-Number: 21493 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 11 Jun 2024 16:20:09 +0000 Gerrit-HasComments: Yes
