Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 )
Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy ...................................................................... Patch Set 1: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/21502/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21502/1//COMMIT_MSG@18 PS1, Line 18: Testing: > Could you add some details about the repro steps? Done http://gerrit.cloudera.org:8080/#/c/21502/1/be/src/runtime/string-value.h File be/src/runtime/string-value.h: http://gerrit.cloudera.org:8080/#/c/21502/1/be/src/runtime/string-value.h@72 PS1, Line 72: static StringValue MakeSmallStringFrom(const StringValue& source) { > I haven't found any usages for this (except in test code). Does this mean t No, we still smallify strings in Tuple::DeepCopy() which is used e.g. by the EXCHANGE nodes. http://gerrit.cloudera.org:8080/#/c/21502/1/be/src/runtime/string-value.h@72 PS1, Line 72: static StringValue MakeSmallStringFrom(const StringValue& source) { > This is only used in the buffered-tuple-stream-test? Are there other places Yes, it is only used by BufferedTupleStream. The only place where we Smallify() currently is in Tuple::DeepCopy() and it deals with tuple slots at a very low-level way, i.e. it memcpys the whole tuple, then invokes Smallify() on the string slots, so we cannot really use this function. http://gerrit.cloudera.org:8080/#/c/21502/1/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/21502/1/tests/query_test/test_join_queries.py@214 PS1, Line 214: def test_spilling_hash_join(self, vector, unique_database): > Could you please add a comment about what this test does? Added a sentence. -- To view, visit http://gerrit.cloudera.org:8080/21502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I739048b37a59a81c41c85d475fad00cb520a5f99 Gerrit-Change-Number: 21502 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 12 Jun 2024 12:50:00 +0000 Gerrit-HasComments: Yes
