Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 )
Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21502/1/be/src/runtime/string-value.h File be/src/runtime/string-value.h: http://gerrit.cloudera.org:8080/#/c/21502/1/be/src/runtime/string-value.h@72 PS1, Line 72: static StringValue MakeSmallStringFrom(const StringValue& source) { > Yes, it is only used by BufferedTupleStream. Ack http://gerrit.cloudera.org:8080/#/c/21502/2/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/21502/2/tests/query_test/test_join_queries.py@219 PS2, Line 219: > flake8: W292 no newline at end of file Going to address this? -- To view, visit http://gerrit.cloudera.org:8080/21502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I739048b37a59a81c41c85d475fad00cb520a5f99 Gerrit-Change-Number: 21502 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 12 Jun 2024 15:37:47 +0000 Gerrit-HasComments: Yes
