Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 )
Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21502/2/be/src/runtime/string-value.h File be/src/runtime/string-value.h: http://gerrit.cloudera.org:8080/#/c/21502/2/be/src/runtime/string-value.h@188 PS2, Line 188: /// !!! THIS IS UNSAFE TO CALL ON EXISTING STRINGVALUE OBJECTS !!! > This seems true for all function that modify the StringValue, e.g. Clear() That would be the ideal thing I think, unfortunately we don't use 'const' enough in the Impala code. Clear()/Assign()/etc. are a bit different, because for those it is obvious that it is not safe to call them, and probably generate errors/bugs more obviously compared to Smallify(), which can remain silent. http://gerrit.cloudera.org:8080/#/c/21502/2/be/src/runtime/string-value.h@190 PS2, Line 190: /// target StringValue object of a deep copy operation. > Can you also add a comment about this to the callsite in tuple.cc? Done, also made Tuple::SmallifyStrings private. http://gerrit.cloudera.org:8080/#/c/21502/2/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/21502/2/tests/query_test/test_join_queries.py@219 PS2, Line 219: > Going to address this? Thanks for reminding me this. Done. -- To view, visit http://gerrit.cloudera.org:8080/21502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I739048b37a59a81c41c85d475fad00cb520a5f99 Gerrit-Change-Number: 21502 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 12 Jun 2024 16:28:37 +0000 Gerrit-HasComments: Yes
