Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 )
Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy ...................................................................... Patch Set 4: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/21502/3/be/src/runtime/string-value-test.cc File be/src/runtime/string-value-test.cc: http://gerrit.cloudera.org:8080/#/c/21502/3/be/src/runtime/string-value-test.cc@81 PS3, Line 81: , cons > Could take const ref. Done http://gerrit.cloudera.org:8080/#/c/21502/3/be/src/runtime/string-value-test.cc@81 PS3, Line 81: Small > Nit: "...Smaller..." would be better. Done http://gerrit.cloudera.org:8080/#/c/21502/3/be/src/runtime/string-value.h File be/src/runtime/string-value.h: http://gerrit.cloudera.org:8080/#/c/21502/3/be/src/runtime/string-value.h@73 PS3, Line 73: DCHECK_LE(source.Len(), SmallableString::SMALL_LIMIT); > Is there a reason why we DCHECK it instead of simply returning a non-smalli To ensure that the user of this function can do anything with the returned object. We could only ensure this for non-small string values if we deep copied them, and that would require a mem pool parameter as well. http://gerrit.cloudera.org:8080/#/c/21502/3/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: http://gerrit.cloudera.org:8080/#/c/21502/3/be/src/runtime/tuple.cc@112 PS3, Line 112: , > Nit: comma instead of period. Done -- To view, visit http://gerrit.cloudera.org:8080/21502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I739048b37a59a81c41c85d475fad00cb520a5f99 Gerrit-Change-Number: 21502 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2024 13:14:22 +0000 Gerrit-HasComments: Yes
