Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21573 )

Change subject: IMPALA-13208: Add cluster id to the membership and 
request-queue topic names
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/scheduling/admission-controller.cc@670
PS1, Line 670:     request_queue_topic_name_ = FLAGS_cluster_id + '-' + 
Statestore::IMPALA_REQUEST_QUEUE_TOPIC;
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/statestore/statestore.cc@1235
PS1, Line 1235:   return ends_with(topic, IMPALA_MEMBERSHIP_TOPIC) || 
ends_with(topic, IMPALA_REQUEST_QUEUE_TOPIC);
line too long (99 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/21573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff41539f568ef03c0ee2284762b4116b313d90f
Gerrit-Change-Number: 21573
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 11 Jul 2024 11:57:05 +0000
Gerrit-HasComments: Yes

Reply via email to