Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21573 )

Change subject: IMPALA-13208: Add cluster id to the membership and 
request-queue topic names
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/21573/2/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:

http://gerrit.cloudera.org:8080/#/c/21573/2/bin/start-impala-cluster.py@89
PS2, Line 89:
> flake8: E501 line too long (91 > 90 characters)
Done


http://gerrit.cloudera.org:8080/#/c/21573/2/bin/start-impala-cluster.py@1151
PS2, Line 1151:
> flake8: E501 line too long (92 > 90 characters)
Done


http://gerrit.cloudera.org:8080/#/c/21573/2/tests/custom_cluster/test_shared_catalogd.py
File tests/custom_cluster/test_shared_catalogd.py:

http://gerrit.cloudera.org:8080/#/c/21573/2/tests/custom_cluster/test_shared_catalogd.py@21
PS2, Line 21: from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite
> flake8: F401 'tests.common.impala_test_suite.IMPALAD_HOSTNAME' imported but
Done


http://gerrit.cloudera.org:8080/#/c/21573/2/tests/custom_cluster/test_shared_catalogd.py@26
PS2, Line 26: class TestSharedCatalogd(CustomClusterTestSuite):
> flake8: E302 expected 2 blank lines, found 1
Done



--
To view, visit http://gerrit.cloudera.org:8080/21573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff41539f568ef03c0ee2284762b4116b313d90f
Gerrit-Change-Number: 21573
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Fri, 12 Jul 2024 06:21:23 +0000
Gerrit-HasComments: Yes

Reply via email to