Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21573 )
Change subject: IMPALA-13208: Add cluster id to the membership and request-queue topic names ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/scheduling/admission-controller.h@915 PS1, Line 915: std::string request_queue_topic_name_; > Yeah, maybe a header file explicitly declares "std::". We use "string" with Ack http://gerrit.cloudera.org:8080/#/c/21573/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/21573/1/bin/start-impala-cluster.py@93 PS1, Line 93: help="Start additional impalad processes.") > --add-executors just adds executors, not coordinators: I guess good enough. We don't have a better term for impalad processes that act as both coordinator and executor to distinguish it from just executors. -- To view, visit http://gerrit.cloudera.org:8080/21573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ff41539f568ef03c0ee2284762b4116b313d90f Gerrit-Change-Number: 21573 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 12 Jul 2024 19:55:23 +0000 Gerrit-HasComments: Yes
