Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21573 )
Change subject: IMPALA-13208: Add cluster id to the membership and request-queue topic names ...................................................................... Patch Set 1: (5 comments) Did you miss adding a custom_cluster file? http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/scheduling/admission-controller.h@915 PS1, Line 915: string request_queue_topic_name_; I'm surprised this works without 'std::'. We tend to avoid relying on 'using' clauses for headers. I'd prefer it match the other uses in this file. http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/scheduling/cluster-membership-mgr.h File be/src/scheduling/cluster-membership-mgr.h: http://gerrit.cloudera.org:8080/#/c/21573/1/be/src/scheduling/cluster-membership-mgr.h@289 PS1, Line 289: string membership_topic_name_; nit: use 'std::string' http://gerrit.cloudera.org:8080/#/c/21573/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/21573/1/bin/start-impala-cluster.py@93 PS1, Line 93: help="Start additional impalad processes.") Can you expand on how this differs from --add-executors? http://gerrit.cloudera.org:8080/#/c/21573/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21573/1/tests/common/custom_cluster_test_suite.py@312 PS1, Line 312: add_impalads=False, I don't see this option used anywhere yet. http://gerrit.cloudera.org:8080/#/c/21573/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21573/1/tests/common/impala_test_suite.py@323 PS1, Line 323: host_port = host_ports[0] Why was this addition necessary? -- To view, visit http://gerrit.cloudera.org:8080/21573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ff41539f568ef03c0ee2284762b4116b313d90f Gerrit-Change-Number: 21573 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2024 16:50:59 +0000 Gerrit-HasComments: Yes
