Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21573 )
Change subject: IMPALA-13208: Add cluster id to the membership and request-queue topic names ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21573/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21573/3//COMMIT_MSG@10 PS3, Line 10: cluster id to the membership One question about subscriber-id. Each statestore subscriber (catalogd/coordinator/executor) send registration info to statestore including subscriber-id, and statestore use it to identify subscribers. subscriber-id is generated as hostname + krpc_port (https://github.com/apache/impala/blob/master/be/src/runtime/exec-env.cc#L286-L289). Can we guarantee subscriber-id unique across multi clusters? Add cluster id as prefix for subscriber id? -- To view, visit http://gerrit.cloudera.org:8080/21573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ff41539f568ef03c0ee2284762b4116b313d90f Gerrit-Change-Number: 21573 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 23:17:04 +0000 Gerrit-HasComments: Yes
