Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21573 )
Change subject: IMPALA-13208: Add cluster id to the membership and request-queue topic names ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21573/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21573/3//COMMIT_MSG@10 PS3, Line 10: cluster id to the membership > Yeah, I think hostname+port should be unique. But I'm ok with adding the cl Ack http://gerrit.cloudera.org:8080/#/c/21573/4/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21573/4/tests/common/impala_test_suite.py@323 PS4, Line 323: host_port = host_ports[0] nit: add a comment here -- To view, visit http://gerrit.cloudera.org:8080/21573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ff41539f568ef03c0ee2284762b4116b313d90f Gerrit-Change-Number: 21573 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 Jul 2024 05:48:21 +0000 Gerrit-HasComments: Yes
