Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21643 )
Change subject: IMPALA-13272: Analyitic function of collections can lead to crash ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21643/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21643/4//COMMIT_MSG@35 PS4, Line 35: a nit: redundant 'a' http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@338 PS4, Line 338: fileds typo: fields http://gerrit.cloudera.org:8080/#/c/21643/4/testdata/workloads/functional-query/queries/QueryTest/sort-complex.test File testdata/workloads/functional-query/queries/QueryTest/sort-complex.test: http://gerrit.cloudera.org:8080/#/c/21643/4/testdata/workloads/functional-query/queries/QueryTest/sort-complex.test@196 PS4, Line 196: select > Here we may need to limit the result set to 2 because I don't think the ord Yeah, it makes sense to exclude the NULLs. How about using inner_struct2 instead of inner_struct1, and use LIMIT 4? -- To view, visit http://gerrit.cloudera.org:8080/21643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71d1fa28ad4ff2e1a8fc5b91d3fc271c33765190 Gerrit-Change-Number: 21643 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 15:47:58 +0000 Gerrit-HasComments: Yes
