Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21643 )
Change subject: IMPALA-13272: Analytic function of collections can lead to crash ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@160 PS4, Line 160: the struct itself also needs to be marked as : * materialized > Added clarification, the struct itself also needs to be marked 'materialize Thank you! I thought the struct itself did not get marked as materialized, so this is very helpful http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@339 PS4, Line 339: if (inputSlotDesc.isFullyMaterialized()) { > Actually if I select all fields in the struct, we run into a NullPointerExc Done -- To view, visit http://gerrit.cloudera.org:8080/21643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71d1fa28ad4ff2e1a8fc5b91d3fc271c33765190 Gerrit-Change-Number: 21643 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 19:47:16 +0000 Gerrit-HasComments: Yes
