Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21643 )
Change subject: IMPALA-13272: Analyitic function of collections can lead to crash ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@160 PS4, Line 160: the struct itself is also marked as : * materialized Nit: this comment by itself is somewhat confusing. Modifying the wording to be something like "the struct itself is also marked as materialized but should not be" add additional context that makes this comment clearer. http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/21643/4/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@339 PS4, Line 339: if (inputSlotDesc.isFullyMaterialized()) { Is there a test case that includes all the fields of a struct so that isFullyMaterialized() returns true? In that case, should the struct's slot descriptor be added to the sorting tuple? -- To view, visit http://gerrit.cloudera.org:8080/21643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71d1fa28ad4ff2e1a8fc5b91d3fc271c33765190 Gerrit-Change-Number: 21643 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 15:57:48 +0000 Gerrit-HasComments: Yes
