Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21643 )
Change subject: IMPALA-13272: Analytic function of collections can lead to crash ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21643/5/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/21643/5/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@a332 PS5, Line 332: nit: Please double check if there is other isMaterialized() call that need to change into isFullyMaterialized(). Otherwise, looks OK to me. -- To view, visit http://gerrit.cloudera.org:8080/21643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71d1fa28ad4ff2e1a8fc5b91d3fc271c33765190 Gerrit-Change-Number: 21643 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 17:21:16 +0000 Gerrit-HasComments: Yes
