Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 )
Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/10158/18/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10158/18/be/src/runtime/coordinator.cc@476 PS18, Line 476: DCHECK(exec_status_.ok()) << exec_status_; > Maybe we can have a larger discussion later, and leave this as it is now. B I was thinking the ($3 -> $4) already gives that info, once you get used to it. For an error that results in query error, it will look like: (EXECUTING -> ERROR) for other errors (that are effectively dropped), it will look like e.g.: (CANCELLED -> CANCELLED) (RETURNED_RESULTS -> RETURNED_RESULTS) (ERROR -> ERROR) which says that we didn't enter the error state for this status. I'm definitely open to tweaking the condition for this log in the future, but just thinking given the amount of active development in the code that will call this path (i.e. IMPALA-2990), it might be helpful to have at least initially. -- To view, visit http://gerrit.cloudera.org:8080/10158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1abdfd02163f9356c59d470fe1c64ebe012a9e8e Gerrit-Change-Number: 10158 Gerrit-PatchSet: 18 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 11 May 2018 21:16:39 +0000 Gerrit-HasComments: Yes
