Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10440 )
Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc@693 PS1, Line 693: // We may start receiving status reports before all exec rpcs are complete. : // Can't apply state transition until no more exec rpcs will be sent. : exec_rpcs_complete_barrier_->Wait(); > this is the fix for IMPALA-7030/IMPALA-7033 race. Also, I plan to add a reg Also note that we are still better off than before this patch because previously, the Coordinator::lock_ was held while sending exec rpcs and also taken by this callback, and so all status report RPCs would block until we finish exec rpcs. Now, we only block a failure status. Also, i plan to improve this further with IMPALA-6788 (which will stop sending exec rpcs once we get the first failure report or exec rpc fails). -- To view, visit http://gerrit.cloudera.org:8080/10440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dc08da1295f1df3c9dce6d35d65d887b2c00a1c Gerrit-Change-Number: 10440 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Comment-Date: Thu, 17 May 2018 17:48:39 +0000 Gerrit-HasComments: Yes
