Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10440 )
Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state ...................................................................... Patch Set 1: (4 comments) This is the same as the previous reviewed patch at https://gerrit.cloudera.org/#/c/10158/ except where noted in this comment. I backed out the change in order to add a fix for IMPALA-7030/7033. http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.h@351 PS1, Line 351: Cannot finalize execution until exec RPCs are no longer : /// being sent. this comment is new http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc@523 PS1, Line 523: // Can't transition until the exec RPCs are no longer in progress. Otherwise, a : // cancel RPC could be missed, and resources freed before a backend has had a chance : // to take a resource reference. : DCHECK(exec_rpcs_complete_barrier_ != nullptr && : exec_rpcs_complete_barrier_->pending() <= 0) << "exec rpcs not completed"; this DCHECK is new http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc@664 PS1, Line 664: PrintId(query_id()) I folded in the PrintId() into this version of the change. http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc@693 PS1, Line 693: // We may start receiving status reports before all exec rpcs are complete. : // Can't apply state transition until no more exec rpcs will be sent. : exec_rpcs_complete_barrier_->Wait(); this is the fix for IMPALA-7030/IMPALA-7033 race. Also, I plan to add a regression test specifically for this race with IMPALA-7046. -- To view, visit http://gerrit.cloudera.org:8080/10440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dc08da1295f1df3c9dce6d35d65d887b2c00a1c Gerrit-Change-Number: 10440 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Comment-Date: Thu, 17 May 2018 17:45:56 +0000 Gerrit-HasComments: Yes
