Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10440 )
Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Bikram may want to take a look too. http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc@693 PS1, Line 693: // We may start receiving status reports before all exec rpcs are complete. : // Can't apply state transition until no more exec rpcs will be sent. : exec_rpcs_complete_barrier_->Wait(); > Also note that we are still better off than before this patch because previ Just to make sure I understand the bug correctly, we only need to wait for exec RPCs for this backend, right? I.e. waiting for all exec RPCs is sufficient but not necessary. Not suggesting we need to change it. -- To view, visit http://gerrit.cloudera.org:8080/10440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dc08da1295f1df3c9dce6d35d65d887b2c00a1c Gerrit-Change-Number: 10440 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 17 May 2018 18:14:49 +0000 Gerrit-HasComments: Yes
