Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21388 )
Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size ...................................................................... Patch Set 12: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21388/12/common/thrift/Query.thrift File common/thrift/Query.thrift: PS12: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new optional fields can be added. http://gerrit.cloudera.org:8080/#/c/21388/12/common/thrift/Query.thrift@946 PS12, Line 946: 1: required TIcebergOptimizationMode mode; Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/21388/12/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/21388/12/tests/query_test/test_iceberg.py@1875 PS12, Line 1875: # flake8: E115 expected an indented block (comment) -- To view, visit http://gerrit.cloudera.org:8080/21388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfbb589513aacdb68a86c1aec4a0d39b12091820 Gerrit-Change-Number: 21388 Gerrit-PatchSet: 12 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 18 Aug 2024 20:18:15 +0000 Gerrit-HasComments: Yes
