Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21388 )
Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size ...................................................................... Patch Set 12: (1 comment) Nice work, Noemi! The code looks great, though I have some concerns what happens when there is an in-progress Zero Downtime Upgrade. http://gerrit.cloudera.org:8080/#/c/21388/12/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/21388/12/common/thrift/Query.thrift@946 PS12, Line 946: 1: required TIcebergOptimizationMode mode; > Modifying/adding this required field might break the compatibility between Somehow we should raise an error when the CatalogD doesn't have the same version as the Coordinator, or maybe we could relax this restriction with some API versioning. Otherwise we would partially truncate a table if the Coordinator has this file filtering OPTIMIZE, but the CatalogD only knows the full table rewriting OPTIMIZE. -- To view, visit http://gerrit.cloudera.org:8080/21388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfbb589513aacdb68a86c1aec4a0d39b12091820 Gerrit-Change-Number: 21388 Gerrit-PatchSet: 12 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 23 Aug 2024 14:10:30 +0000 Gerrit-HasComments: Yes
