Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21388 )
Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size ...................................................................... Patch Set 12: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21388/12/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/21388/12/common/thrift/Query.thrift@946 PS12, Line 946: 1: required TIcebergOptimizationMode mode; > Somehow we should raise an error when the CatalogD doesn't have the same ve I think we can ignore this, as OPTIMIZE FILE_SIZE_THRESHOLD_MB is introduced by this patch, i.e. users will only execute this statement when they have already upgraded to a version that has this. They won't just start using a new feature mid-upgrade. We will need to consider compatibility issues for statements that are already supported and we just want to improve them. -- To view, visit http://gerrit.cloudera.org:8080/21388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfbb589513aacdb68a86c1aec4a0d39b12091820 Gerrit-Change-Number: 21388 Gerrit-PatchSet: 12 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sat, 24 Aug 2024 18:54:38 +0000 Gerrit-HasComments: Yes
