Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21388 )
Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size ...................................................................... Patch Set 12: (3 comments) Thanks Noémi, only a few comments, otherwise good for me. http://gerrit.cloudera.org:8080/#/c/21388/12/fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java File fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java: http://gerrit.cloudera.org:8080/#/c/21388/12/fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java@74 PS12, Line 74: converted Nit: "is converted" http://gerrit.cloudera.org:8080/#/c/21388/12/fe/src/test/java/org/apache/impala/util/IcebergFileFilterTest.java File fe/src/test/java/org/apache/impala/util/IcebergFileFilterTest.java: http://gerrit.cloudera.org:8080/#/c/21388/12/fe/src/test/java/org/apache/impala/util/IcebergFileFilterTest.java@129 PS12, Line 129: // the partition. Nit: could add: "so it will not be rewritten". http://gerrit.cloudera.org:8080/#/c/21388/11/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/21388/11/tests/query_test/test_iceberg.py@1872 PS11, Line 1872: # Only new partitions are written to. Is it intentional that you removed this line? -- To view, visit http://gerrit.cloudera.org:8080/21388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfbb589513aacdb68a86c1aec4a0d39b12091820 Gerrit-Change-Number: 21388 Gerrit-PatchSet: 12 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2024 14:48:58 +0000 Gerrit-HasComments: Yes
