Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21653 )
Change subject: IMPALA-12737: Refactor the Workload Management Initialization Process. ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc@152 PS10, Line 152: static string > Might be more convenient to return NO_TABLE_EXIST constant instead of empty Yes, that would really clarify the code a lot. Implementing... http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc@199 PS10, Line 199: VERSION_1_0_0 > Can define CURRENT_VERSION constant for this comparison. Patch https://gerrit.cloudera.org/#/c/21142/ removes the hardcoded versions in favor of a sorted set of all known schema versions. I would prefer to leave this patch as-is and let 21142 take care of it. http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc@224 PS10, Line 224: // Create and/or update the completed queries table if needed. > Put query_log_table initialization into its own function? Patch https://gerrit.cloudera.org/#/c/21142/ has the query log table init process split into its own function. I would prefer to let that patch take care of the function split. http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc@254 PS10, Line 254: : // Create and/or update the live queries table if needed. : // Determine the live queries table name. > Put query_live_table initialization into its own function? Patch https://gerrit.cloudera.org/#/c/21142/ has the live queries table init process split into its own function. I would prefer to let that patch take care of the function split. -- To view, visit http://gerrit.cloudera.org:8080/21653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id645f94c8da73b91c13a23d7ac0ea026425f0f96 Gerrit-Change-Number: 21653 Gerrit-PatchSet: 10 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 22 Aug 2024 16:56:54 +0000 Gerrit-HasComments: Yes
