Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21653 )
Change subject: IMPALA-12737: Refactor the Workload Management Initialization Process. ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/21653/11/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21653/11/be/src/service/workload-management-init.cc@193 PS11, Line 193: /// Warns if the target_ver is less than the actual_ver. > That is a very good point. I don't see where it would harm anything to run If this is true, maybe also write "Only columns in target schema version will be written to the table." That would be my expectation, and it would be nice for the warning to clarify what the behavior will be. http://gerrit.cloudera.org:8080/#/c/21653/12/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21653/12/be/src/service/workload-management-init.cc@198 PS12, Line 198: table_name << "' table is lower than the actual schema version '" << > line has trailing whitespace It'd be nice to clean this up. -- To view, visit http://gerrit.cloudera.org:8080/21653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id645f94c8da73b91c13a23d7ac0ea026425f0f96 Gerrit-Change-Number: 21653 Gerrit-PatchSet: 12 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 22 Aug 2024 19:01:25 +0000 Gerrit-HasComments: Yes
