Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21653 )
Change subject: IMPALA-12737: Refactor the Workload Management Initialization Process. ...................................................................... Patch Set 11: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc@152 PS10, Line 152: static Versio > Yes, that would really clarify the code a lot. Implementing... Done http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc@199 PS10, Line 199: , "'. Downgra > Patch https://gerrit.cloudera.org/#/c/21142/ removes the hardcoded versions Ack http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc@224 PS10, Line 224: FLAGS_workload_mgmt_schema_version, "'")); > Patch https://gerrit.cloudera.org/#/c/21142/ has the query log table init p Ack http://gerrit.cloudera.org:8080/#/c/21653/10/be/src/service/workload-management-init.cc@254 PS10, Line 254: parsed_actual_schema_version = _retrieveSchemaVersion(internal_server_.get(), : log_table_name, insert_query_opts); : > Patch https://gerrit.cloudera.org/#/c/21142/ has the live queries table ini Ack -- To view, visit http://gerrit.cloudera.org:8080/21653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id645f94c8da73b91c13a23d7ac0ea026425f0f96 Gerrit-Change-Number: 21653 Gerrit-PatchSet: 11 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 22 Aug 2024 18:48:00 +0000 Gerrit-HasComments: Yes
