Hello Riza Suminto, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21653
to look at the new patch set (#12).
Change subject: IMPALA-12737: Refactor the Workload Management Initialization
Process.
......................................................................
IMPALA-12737: Refactor the Workload Management Initialization Process.
The workload management initialization process creates the two tables
"sys.impala_query_log" and "sys.impala_query_live" during coordinator
startup.
The current design for this init process is to create both tables on
each coordinator at every startup by running create database and
create table if not exists DDLs. This design causes unnecessary DDLs
to execute which delays coordinator startup and introduces the
potential for unnecessary startup failures should the DDLs fail.
This patch splits the initialization code into its own file and adds
version tracking to the individual fields in the workload management
tables. This patch also adds schema version checks on the workload
management tables and only runs DDLs for the db tables if necessary.
Additionally, versioning of workload management table schemas is
introduced. The only allowed schema version in this patch is 1.0.0.
Future patches that need to modify the workload management table
schema will expand this list of allowed versions.
Since this patch is a refactor and does not change functionality,
testing was accomplished by running existing workload management
unit and python tests.
Change-Id: Id645f94c8da73b91c13a23d7ac0ea026425f0f96
---
M be/src/service/CMakeLists.txt
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/service/workload-management-fields.cc
M be/src/service/workload-management-flags.cc
A be/src/service/workload-management-init.cc
M be/src/service/workload-management.cc
M be/src/service/workload-management.h
M be/src/util/CMakeLists.txt
A be/src/util/version-util-test.cc
A be/src/util/version-util.cc
A be/src/util/version-util.h
M tests/custom_cluster/test_query_live.py
M tests/custom_cluster/test_query_log.py
14 files changed, 681 insertions(+), 235 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/21653/12
--
To view, visit http://gerrit.cloudera.org:8080/21653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id645f94c8da73b91c13a23d7ac0ea026425f0f96
Gerrit-Change-Number: 21653
Gerrit-PatchSet: 12
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
