Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21653 )
Change subject: IMPALA-12737: Refactor the Workload Management Initialization Process. ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/21653/11/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21653/11/be/src/service/workload-management-init.cc@193 PS11, Line 193: /// Aborts with error if the target_ver is less than the actual_ver. > I'd outlined a set of upgrade tests that I think will need that support. Th Yes, that is what we support. I added tests to https://gerrit.cloudera.org/#/c/21142/. At this point, I think we should close this change and move its code to 21142. This change by itself doesn't actually add much, a lot of what was added got refactored away in 21142, and some of its testing is done in 21142. Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/21653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id645f94c8da73b91c13a23d7ac0ea026425f0f96 Gerrit-Change-Number: 21653 Gerrit-PatchSet: 11 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 22 Aug 2024 20:32:01 +0000 Gerrit-HasComments: Yes
