Riza Suminto has uploaded this change for review. (
http://gerrit.cloudera.org:8080/21726
Change subject: IMPALA-13330: Fix orc_schema_resolution in test_nested_types.py
......................................................................
IMPALA-13330: Fix orc_schema_resolution in test_nested_types.py
test_nested_types.py declare 'orc_schema_resolution' dimension, but does
not actually exercise it. None of the test actively inserting
'orc_schema_resolution' dimension value into
vector.get_value('exec_dimension').
This patch fix that issue by declaring 'orc_schema_resolution' option
using helper function add_exec_option_dimension() to automatically
insert it into 'exec_option' dimension. Test classes also reorganized to
reduce test skipping and deepcopy-ing.
Following are notable changes:
- Use 'unique_database' in test_struct_in_select_list to avoid collision
during view creation.
- Drop unused 'unique_database' fixture in
TestNestedCollectionsInSelectList.
- test_map_null_keys does not have 'mt_dop' dimension anymore since it
only test how NULL map key are displayed.
- Created common base class TestParquetArrayEncodingsBase for
TestParquetArrayEncodings and TestParquetArrayEncodingsAmbiguous. The
latter does not run with 'parquet_array_resolution' anymore since that
query option is set directly within parquet-ambiguous-list-modern.test
and parquet-ambiguous-list-legacy.test files.
- Make ImpalaTestMatrix.add_dimensions() call
ImpalaTestMatrix.clear_dimension() if given dimension.name is
'exec_option' and independent_exec_option_names is not empty.
The reduction of test count are follows:
Before patch:
168 core tests, 571 exhaustive tests
After patch:
161 core tests, 529 exhaustive tests
Testing:
- Ran and pass test_nested_types.py in exhaustive exploration.
- Verified that no WARNING log printed by
ImpalaTestSuite.validate_exec_option_dimension()
Change-Id: Ib958cd34a56c949190b4f22e5da5dad2c0de25ff
---
M
testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list.test
M tests/common/test_vector.py
M tests/query_test/test_nested_types.py
3 files changed, 144 insertions(+), 107 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/21726/1
--
To view, visit http://gerrit.cloudera.org:8080/21726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib958cd34a56c949190b4f22e5da5dad2c0de25ff
Gerrit-Change-Number: 21726
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <[email protected]>
