Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21726 )
Change subject: IMPALA-13330: Fix orc_schema_resolution in test_nested_types.py ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@133 PS1, Line 133: 'mt_dop': MT_DOP_DIMS})) > I can move MT_DOP inside create_exec_option_dimension_from_dict, but not OR Thanks, then I think it's good to move MT_DOP inside the dict and leave ORC_SCHEMA_RESOLUTION as it is now. http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@404 PS1, Line 404: super(TestNestedTypesNoMtDopOrc, cls).add_test_dimensions() > It actually still have it,because, underneath, the superclass ImpalaTestSui You're right, thanks. -- To view, visit http://gerrit.cloudera.org:8080/21726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib958cd34a56c949190b4f22e5da5dad2c0de25ff Gerrit-Change-Number: 21726 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2024 09:30:47 +0000 Gerrit-HasComments: Yes
