Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21726 )
Change subject: IMPALA-13330: Fix orc_schema_resolution in test_nested_types.py ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@133 PS1, Line 133: add_exec_option_dimension(cls, 'mt_dop', MT_DOP_DIMS) Can't MT_DOP and ORC_RESOLUTION_DIM be added to the dict in the call to create_exec_option_dimension_from_dict()? See also L189 and L222. http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@404 PS1, Line 404: def test_map_null_keys(self, vector): This test now doesn't have the exec options it used to, set on L182: disable_codegen, disable_codegen_rows_threshold and exec_single_node_rows_threshold. http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@446 PS1, Line 446: ORC Shouldn't it be Parquet? http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@455 PS1, Line 455: add_exec_option_dimension(cls, 'orc_schema_resolution', ORC_RESOLUTION_DIMS) Do we need this and the 'orc_schema_resolution_constraint' if it is only run with Parquet? -- To view, visit http://gerrit.cloudera.org:8080/21726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib958cd34a56c949190b4f22e5da5dad2c0de25ff Gerrit-Change-Number: 21726 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:13:42 +0000 Gerrit-HasComments: Yes
