Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21726 )
Change subject: IMPALA-13330: Fix orc_schema_resolution in test_nested_types.py ...................................................................... Patch Set 2: (4 comments) Thank you for the review. http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@133 PS1, Line 133: 'mt_dop': MT_DOP_DIMS})) > Can't MT_DOP and ORC_RESOLUTION_DIM be added to the dict in the call to cre I can move MT_DOP inside create_exec_option_dimension_from_dict, but not ORC_RESOLUTION_DIM, because orc_schema_resolution_constraint() look for the value in vector.get_value('orc_schema_resolution') . If declaring option using create_exec_option_dimension_from_dict(), the value exist directly in vector.get_value('exec_option')['orc_schema_resolution']. http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@404 PS1, Line 404: super(TestNestedTypesNoMtDopOrc, cls).add_test_dimensions() > This test now doesn't have the exec options it used to, set on L182: disabl It actually still have it,because, underneath, the superclass ImpalaTestSuite.add_test_dimensions() calls create_exec_option_dimension() that is superset of dictionary in L182. ALL_BATCH_SIZES = [0] ALL_CLUSTER_SIZES = [0, 1] SINGLE_NODE_ONLY = [1] ALL_NODES_ONLY = [0] ALL_DISABLE_CODEGEN_OPTIONS = [True, False] def create_exec_option_dimension(cluster_sizes=ALL_NODES_ONLY, disable_codegen_options=ALL_DISABLE_CODEGEN_OPTIONS, batch_sizes=ALL_BATCH_SIZES, sync_ddl=None, exec_single_node_option=[0], # We already run with codegen on and off explicitly - # don't need automatic toggling. disable_codegen_rows_threshold_options=[0], debug_action_options=None): The next call to add_exec_option_dimension(cls, 'orc_schema_resolution', ORC_RESOLUTION_DIMS) does not override the existing 'exec_option' dimension, only increasing it later in vector generation. http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@446 PS1, Line 446: par > Shouldn't it be Parquet? Done http://gerrit.cloudera.org:8080/#/c/21726/1/tests/query_test/test_nested_types.py@455 PS1, Line 455: def get_workload(self): > Do we need this and the 'orc_schema_resolution_constraint' if it is only ru Removed. -- To view, visit http://gerrit.cloudera.org:8080/21726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib958cd34a56c949190b4f22e5da5dad2c0de25ff Gerrit-Change-Number: 21726 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2024 15:29:33 +0000 Gerrit-HasComments: Yes
