Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21726 )
Change subject: IMPALA-13330: Fix orc_schema_resolution in test_nested_types.py ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21726/2/tests/common/test_vector.py File tests/common/test_vector.py: http://gerrit.cloudera.org:8080/#/c/21726/2/tests/common/test_vector.py@133 PS2, Line 133: self.dimensions[dimension.name] = dimension > Should we warn when we do this? Seems like a test config mistake if we're r Make sense. Added WARNING log if removal happens here. TestParquetArrayEncodingsAmbiguous also updated to simply clear 'parquet_array_resolution' from ImpalaTestMatrix. -- To view, visit http://gerrit.cloudera.org:8080/21726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib958cd34a56c949190b4f22e5da5dad2c0de25ff Gerrit-Change-Number: 21726 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2024 21:26:20 +0000 Gerrit-HasComments: Yes
