Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21778
Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() ...................................................................... IMPALA-13371: Avoid throwing exception in FindFileInPath() Some std::filesystem:: functions can throw exceptions, which led to crash without informative error when FileSystemUtil::FindFileInPath() bumped into a problematic path in JavaAddJammAgent(). Fixed by switching to overloads of the functions that can't throw exception (other functions in FileSystemUtil already used these). Testing: - Reproduced the crash manually with paths where Impala didn't have permission and checked that now Impala logs the path and error. Not sure if this would work reliably in other environments, so didn't add automatic tests. Change-Id: I6ed9f288ac5c400778a6b1215e16baf191bf5d0c --- M be/src/common/init.cc M be/src/util/filesystem-util-test.cc M be/src/util/filesystem-util.cc M be/src/util/filesystem-util.h 4 files changed, 52 insertions(+), 30 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/21778/2 -- To view, visit http://gerrit.cloudera.org:8080/21778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6ed9f288ac5c400778a6b1215e16baf191bf5d0c Gerrit-Change-Number: 21778 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]>
