Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21778 )
Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/common/init.cc@355 PS2, Line 355: Status status = FileSystemUtil::FindFileInPath(test_path, "jamm-.*.jar", &jamm_path); > Changed to just logging an error. Not sure what will happen in this case la That would have been an issue before as well. Presumably Java just ignores the unreadable path. http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/util/filesystem-util.cc File be/src/util/filesystem-util.cc: http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/util/filesystem-util.cc@154 PS2, Line 154: DCHECK(is_dir != nullptr); > Done Ack http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/util/filesystem-util.cc@277 PS2, Line 277: boost::algorithm::trim_right_if(path, boost::algorithm::is_any_of("*")); > Done Ack -- To view, visit http://gerrit.cloudera.org:8080/21778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed9f288ac5c400778a6b1215e16baf191bf5d0c Gerrit-Change-Number: 21778 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2024 18:19:11 +0000 Gerrit-HasComments: Yes
