Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21778 )
Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/common/init.cc@355 PS2, Line 355: RETURN_IF_ERROR(FileSystemUtil::FindFileInPath(test_path, "jamm-.*.jar", &jamm_path)); I'd be inclined to log a warning here and continue. But I suppose it's a little strange for CLASSPATH to include a path Impala can't read. http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/util/filesystem-util.cc File be/src/util/filesystem-util.cc: http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/util/filesystem-util.cc@154 PS2, Line 154: *is_dir = filesystem::is_directory(path, errcode); DCHECK is_dir != nullptr before use. http://gerrit.cloudera.org:8080/#/c/21778/2/be/src/util/filesystem-util.cc@277 PS2, Line 277: *result = ""; Should probably DCHECK that result != nullptr. -- To view, visit http://gerrit.cloudera.org:8080/21778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed9f288ac5c400778a6b1215e16baf191bf5d0c Gerrit-Change-Number: 21778 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2024 16:40:18 +0000 Gerrit-HasComments: Yes
