Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21778 )
Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21778/3/be/src/util/filesystem-util-test.cc File be/src/util/filesystem-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21778/3/be/src/util/filesystem-util-test.cc@141 PS3, Line 141: ASSERT_OK(FileSystemUtil::FindFileInPath(dir.string(), "a.*1", &path)); > That would depend on running as a non-root user. Are there cases where we want to run as root? Precommit uses a regular user. -- To view, visit http://gerrit.cloudera.org:8080/21778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed9f288ac5c400778a6b1215e16baf191bf5d0c Gerrit-Change-Number: 21778 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 11 Sep 2024 01:51:59 +0000 Gerrit-HasComments: Yes
