Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21565 )
Change subject: IMPALA-13197: Implement Analytic Exprs for Calcite ...................................................................... Patch Set 8: Here is a report for this change: https://jenkins.impala.io/view/all/job/calcite-report-prototype/10/artifact/Impala/calcite_report/html/index.html It can trigger a crash on this assert: https://github.com/apache/impala/blob/master/be/src/exec/analytic-eval-node.cc#L69 I changed that location to return status rather than asserting, and you can see some statements hitting that in: https://jenkins.impala.io/view/all/job/calcite-report-prototype/10/artifact/Impala/calcite_report/html/query_test_test_queries.py/TestQueries_test_analytic_fns/output_40188614b0b3d79973423e1ba14e57daf544d34512f8a01846f9e5c74aa8e8e7.html -- To view, visit http://gerrit.cloudera.org:8080/21565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba5060546a7568ba0cd315f546daa78d89b1c3c5 Gerrit-Change-Number: 21565 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2024 16:35:32 +0000 Gerrit-HasComments: No
