Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21565 )
Change subject: IMPALA-13197: Implement Analytic Exprs for Calcite ...................................................................... IMPALA-13197: Implement Analytic Exprs for Calcite An analytic expression is represented with a RexOver type RexNode within Calcite. They will exist within the Project RelNode. If there are any RexOvers existing within the Project, then the ImpalaAnalyticRel RelNode gets created instead of the ImpalaProjectRel. Only bare bones test cases are included. There are quite a number of analytic expressions that will not work. The logic is included in the AnalyticExpr.standardize() method. Another commit will be needed to support all general analytic expressions and the tests within Impala will be used for testing purposes. Change-Id: Iba5060546a7568ba0cd315f546daa78d89b1c3c5 Reviewed-on: http://gerrit.cloudera.org:8080/21565 Reviewed-by: Joe McDonnell <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Michael Smith <[email protected]> --- M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedAnalyticExpr.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ConvertToImpalaRelRules.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java M testdata/workloads/functional-query/queries/QueryTest/calcite.test 7 files changed, 664 insertions(+), 5 deletions(-) Approvals: Joe McDonnell: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iba5060546a7568ba0cd315f546daa78d89b1c3c5 Gerrit-Change-Number: 21565 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
