Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21565 )
Change subject: IMPALA-13197: Implement Analytic Exprs for Calcite ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/21565/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/21565/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@146 PS9, Line 146: Collections.emptyList(), new ArrayList<>() > These two params control a small optimization in DistributedPlanner that ca Ack http://gerrit.cloudera.org:8080/#/c/21565/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@315 PS9, Line 315: List<AnalyticExpr> analyticExprs = new ArrayList<>(); > FYI: Recently, Michael improved Exprs to allow them to be hashed, so variou Ack -- To view, visit http://gerrit.cloudera.org:8080/21565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba5060546a7568ba0cd315f546daa78d89b1c3c5 Gerrit-Change-Number: 21565 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 09 Oct 2024 20:39:18 +0000 Gerrit-HasComments: Yes
