Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21565 )
Change subject: IMPALA-13197: Implement Analytic Exprs for Calcite ...................................................................... Patch Set 9: Code-Review+1 (2 comments) This looks good. We know that it moves things in the right direction from the report and there are follow-up changes to address limitations. Unless there are other comments, I will +2 http://gerrit.cloudera.org:8080/#/c/21565/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/21565/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@146 PS9, Line 146: Collections.emptyList(), new ArrayList<>() These two params control a small optimization in DistributedPlanner that can reduce the number of exchanges in some cases. We have bigger fish to fry, but I will file a JIRA to track that as a known difference in optimization. The original change is here: https://github.com/apache/impala/commit/0b3124ab35402f1ab8141e8ffcca28a5a481c81e http://gerrit.cloudera.org:8080/#/c/21565/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@315 PS9, Line 315: List<AnalyticExpr> analyticExprs = new ArrayList<>(); FYI: Recently, Michael improved Exprs to allow them to be hashed, so various algorithms that required O(n) algorithms could be adapted to use a hash-based approach. In theory, this List could be a HashMap. I'm not requiring that to be changed in this review, but I want you to be aware of that new possibility. -- To view, visit http://gerrit.cloudera.org:8080/21565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba5060546a7568ba0cd315f546daa78d89b1c3c5 Gerrit-Change-Number: 21565 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 09 Oct 2024 19:15:42 +0000 Gerrit-HasComments: Yes
