Anonymous Coward (816) has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/21575/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java: http://gerrit.cloudera.org:8080/#/c/21575/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java@96 PS8, Line 96: public class ImpalaMinusToDistinctRule > Yes, that's something I'm looking at. hi, my naive idea is we need to extendes SqlToRelConverter, and overrides some methods, such as convertWith(), convertFrom(), convertIdentifier()... and add some logical relnodes, such as LogicalCteAnchor, LogicalCteProducer, LogicalCteConsumer add some rules for LogicalCteAnchor, LogicalCteProducer, LogicalCteConsumer -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 11 Oct 2024 13:19:28 +0000 Gerrit-HasComments: Yes
