Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/codegen/templates/Parser.jj@4654 PS9, Line 4654: <QUOTED_IDENTIFIER> > The latest patch actually has an extra fix. Just added one more fix. Some queries were failing in "TestAlias" in the ParserTest unit test which are now fixed (the unit test for Calcite on ParserTest will be committed in the very near future) I had to add a function which handles places where Impala allows both quotes and unquoted string literals. This occurs in select clauses, table aliases, and with clauses -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 13 Oct 2024 14:58:27 +0000 Gerrit-HasComments: Yes
