Anonymous Coward (816) has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/21575/17/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java: http://gerrit.cloudera.org:8080/#/c/21575/17/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java@48 PS17, Line 48: public class ExtractLiteralAgg extends RelOptRule { https://github.com/apache/kylin/blob/kylin5/src/query/src/main/java/org/apache/kylin/query/optrule/AggregateMultipleExpandRule.java if we add this rule, can we get rid of the functions that specific to impala, such as aggif() and ValidTupleIdExpr described in MultiAggregateInfo.java? -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 17 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 02:57:49 +0000 Gerrit-HasComments: Yes
